Repository navigation
feat(linux): support frame-pointer-only recording - #12
Merged
Merged
Conversation
not-matthias
marked this pull request as ready for review
October 13, 2026 15:45
GuillaumeLagrange
force-pushed
the
codspeed
branch
from
October 30, 2026 13:37
2eaaf6e to
3894fb7
Compare
GuillaumeLagrange
left a comment
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
@not-matthias could you clean up a bit this pr after my forcepush of codspeed? I think it includes some commits that should not appear here because of me 😬
not-matthias
force-pushed
the
cod-3861-support-samply-fp-unwinding
branch
from
November 2, 2026 15:47
ad8f286 to
fa031b6
Compare
not-matthias
requested review from
GuillaumeLagrange
and removed request for
GuillaumeLagrange
November 2, 2026 15:51
not-matthias
force-pushed
the
cod-3861-support-samply-fp-unwinding
branch
from
November 2, 2026 15:55
fa031b6 to
28c561b
Compare
GuillaumeLagrange
approved these changes
Nov 3, 2026
Remove redundant formatting and unused imports, provide Default implementations, and name specialized iterator conversions explicitly. Use Infallible for the Linux profiler, which never returns Err.
Add --unwinding-mode fp and dwarf,<bytes> while preserving the default DWARF stack size. Configure perf callchains, user registers, and stack copying for the selected mode. Document frame-pointer requirements and cover CLI validation.
not-matthias
force-pushed
the
cod-3861-support-samply-fp-unwinding
branch
from
November 3, 2026 14:46
acac9ff to
37b48c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Add
samply record --unwinding-mode fpto use kernel frame-pointer callchains without copying user stacks or registers (Linux only).dwarfas the default with the existing kernel-FP fallback; preserve FP mode for launch, PID attach, and software-event fallback.cargo test -p samply --locked: 28 passed, one existing ignored test.FP stacks require preserved frame pointers throughout the call chain and remain subject to kernel/architecture support and callchain depth limits.
Refs COD-3861.